RFR: 8311557: [JVMCI] deadlock with JVMTI thread suspension [v2]

[Tom Rodriguez]

On Wed, 9 Aug 2023 20:55:32 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Refactor logic and add LibJVMCICompilerThreadHidden
>>  - Merge branch 'master' into tkr-jvmci-hidden
>>  - 8311557: [JVMCI] deadlock with JVMTI thread suspension
>
> src/hotspot/share/compiler/abstractCompiler.hpp line 154:
> 
>> 152:   CompilerType type() const              { return _type; }
>> 153: 
>> 154:   virtual bool is_hidden_from_external_view() const { return false; }
> 
> It would be nice if this had a comment explaining what "hidden from external view" implies. But I see that `Thread::is_hidden_from_external_view` has no documentation either so I guess there's no much that can be explained here if the broader concept is somewhat undefined.

I added a comment in CompilerThread.

> src/hotspot/share/jvmci/jvmciCompiler.hpp line 107:
> 
>> 105: 
>> 106:   virtual bool is_hidden_from_external_view() const { return UseJVMCINativeLibrary && LibJVMCICompilerThreadHidden; }
>> 107: 
> 
> Remove extra blank line.

Ok

> src/hotspot/share/jvmci/jvmci_globals.hpp line 162:
> 
>> 160:   product(bool, LibJVMCICompilerThreadHidden, true, DIAGNOSTIC,             \
>> 161:           "If true then native JVMCI compiler threads are hidden from "     \
>> 162:           "JVMTI and FlightRecorder.  This must be set to false if you"     \
> 
> `you"` -> `you "`
> `threads"` -> `threads."`
> 
> As far as I can help, this help text is never printed (is it?) but it may as well be properly formatted.

Fixed.  It's not in the product but it does function a documentation for the options.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14799#discussion_r1289405007
PR Review Comment: https://git.openjdk.org/jdk/pull/14799#discussion_r1289404492
PR Review Comment: https://git.openjdk.org/jdk/pull/14799#discussion_r1289404280