RFR: 8312547: Max/Min nodes Value implementation could be improved [v2]

[Tobias Hartmann]

On Tue, 25 Jul 2023 18:38:06 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch removes the early return in `AddNode::Value` in case one of the inputs is a bottom, which may affect the value calculation of nodes such as `Min/MaxNode`.
>> 
>> Please kindly review, thanks very much.
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix min/maxfp nodes

Looks good to me.

src/hotspot/share/opto/addnode.cpp line 220:

> 218:   // Either input is TOP ==> the result is TOP
> 219:   const Type *t1 = phase->type(in(1));
> 220:   const Type *t2 = phase->type(in(2));

Suggestion:

  const Type* t1 = phase->type(in(1));
  const Type* t2 = phase->type(in(2));

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15021#pullrequestreview-1571131511
PR Review Comment: https://git.openjdk.org/jdk/pull/15021#discussion_r1289632391