RFR: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests [v4]
Vladimir Kozlov
kvn at openjdk.org
Thu Aug 10 16:37:28 UTC 2023
On Wed, 9 Aug 2023 09:13:28 GMT, Pengfei Li <pli at openjdk.org> wrote:
>> This patch removes `@require vm.flagless` annotations from HotSpot jtreg tests in `compiler/vectorization/runner`. All jtreg cases in this folder are invoked by test driver `VectorizationTestRunner.java` which checks both correctness and vectorizability (IR) for each test method. We added flagless requirement before because extra flags may mess with compiler control in the test driver for correctness check. But `flagless` has a side effect that it makes tests with extra flags skipped. So we propose to get rid of it now.
>>
>> To adapt the removal of `@require vm.flagless`, a few checks are added in the test driver to skip the correctness check if extra flags make the compiler control not work. This patch also moves previously hard-coded flag `-XX:-OptimizeFill` in the test driver to conditions in IR checks.
>>
>> Tested various of compiler control related VM flags on x86 and AArch64.
>
> Pengfei Li has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove useless conditions and imports
I am fine with update.
-------------
Marked as reviewed by kvn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15011#pullrequestreview-1572286304
More information about the hotspot-compiler-dev
mailing list