RFR: 8310308: IR Framework: check for type and size of vector nodes [v26]
Emanuel Peter
epeter at openjdk.org
Mon Aug 14 14:12:29 UTC 2023
On Wed, 9 Aug 2023 10:31:57 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 71 commits:
>>
>> - manual merge from master
>> - duplicate rules in VectorLogicalOpIdentityTest.java
>> - Merge branch 'master' into JDK-8310308
>> - Duplicated =1 counts for vector nodes in compiler/vectorapi/reshape/tests/TestVectorCast.java
>> - Merge branch 'master' into JDK-8310308
>> - Fix with canTrustVectorSize for Cascade Lake
>> - TestSpillTheBeans.java
>> - print VMInfo from Test VM
>> - merge from master, manual merge for VectorLogicalOpIdentityTest.java
>> - Response to Tobias' review
>> - ... and 61 more: https://git.openjdk.org/jdk/compare/509f80bb...48fa52ba
>
> test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java line 108:
>
>> 106: private static final String LOAD_OF_CLASS_POSTFIX = "(:|\\+)\\S* \\*" + END;
>> 107:
>> 108: public static final String IMPOSSIBLE_NODE_REGEX = "impossible_node_regex";
>
> Maybe add additional `#` to be on the safe side to never accidentally match it:
> Suggestion:
>
> public static final String IMPOSSIBLE_NODE_REGEX = "#impossible_node_regex#";
Line is now removed, not required any more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1293500774
More information about the hotspot-compiler-dev
mailing list