RFR: 8310308: IR Framework: check for type and size of vector nodes [v30]

[Emanuel Peter]

On Mon, 14 Aug 2023 13:35:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments according to TobiHartmann
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/parser/VMInfo.java line 67:
> 
>> 65:             System.err.println("   -> SuperWord expected to run with 32 byte, not 64 byte, VectorAPI expected to use 64 byte");
>> 66:             System.err.println("   -> \"canTrustVectorSize == false\", some vector node IR rules are made weaker.");
>> 67:         }
> 
> Is this a leftover from debugging? If you want to print this information for debugging purposes, I suggest to move this code to `VMInfoParser` and additionally guard it with `VERBOSE || PRINT_IR_ENCODING`. The name `PRINT_IR_ENCODING` is not completely correct here but we might want to clean this up separately at some other point in time.
> 
> You can keep the verification of calling the `get*()` methods here, though.

I can just remove it. It is not necessary any more I think.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14539#discussion_r1293515743