RFR: 8313760: [REDO] Enhance AES performance
Christian Hagedorn
chagedorn at openjdk.org
Tue Aug 15 12:37:08 UTC 2023
On Tue, 15 Aug 2023 12:30:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>>> @chhagedorn Reviewer `adinn` has already made an authenticated review of this PR, and does not need to be credited manually.
>>
>> @adinn I'm not sure why it says that but does not list you above. Maybe you need to explicitly approve the PR again to appear in the reviewer list again.
>
>>> Reviewer adinn has already made an authenticated review of this PR, and does not need to be credited manually.
>>
>> @adinn I'm not sure why it says that but does not list you above. Maybe you need to explicitly approve the PR again to appear in the reviewer list again.
>
> Yes, GitHub now sees @adinn as having reviewed, but without approving it, so Skara will not allow him to be added manually. If he reviews / approves, he will then be listed.
Thanks @kevinrushforth for the explanation!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15267#issuecomment-1678856431
More information about the hotspot-compiler-dev
mailing list