RFR: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests [v2]

[Emanuel Peter]

On Wed, 9 Aug 2023 09:15:28 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> @vnkozlov @TobiHartmann we should re-run testing from our side.
>> 
>> @pfustc Why do you only test correctness (compare results) in some conditions? Is there not a risk that we miss doing it in some cases we should do it, just because we get the conditions slightly wrong?
>> 
>> Just FYI: we should integrate this whole correctness of results testing into the IR framework. I filed [JDK-8310533](https://bugs.openjdk.org/browse/JDK-8310533). That would make it easier to use for new tests. It could also be used for any test, not just the ones located in `test/hotspot/jtreg/compiler/vectorization`.
>
> Hi @eme64 ,
> 
> Thanks for looking at this.
> 
>> @pfustc Why do you only test correctness (compare results) in some conditions? Is there not a risk that we miss doing it in some cases we should do it, just because we get the conditions slightly wrong?
> 
> Yes, you are right! These conditions are added before to avoid jtreg hanging when compilation is locked. But now I can remove them because the lock is removed. In my latest commit, I have removed the conditions and some useless imports.
> 
>> Just FYI: we should integrate this whole correctness of results testing into the IR framework. I filed [JDK-8310533](https://bugs.openjdk.org/browse/JDK-8310533). That would make it easier to use for new tests. It could also be used for any test, not just the ones located in test/hotspot/jtreg/compiler/vectorization.
> 
> I have noticed this JBS before. The reason I didn't added correctness check into the IR framework is that I implemented this kind of check before the IR framework exists. (We have used it internally for a few years.) But anyway, it is a good proposal and I'm willing to help if needed.

@pfustc Since you are working on IR tests here, it would be good if you first merge the changes from [JDK-8310308](https://bugs.openjdk.org/browse/JDK-8310308), and test the IR rules again.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15011#issuecomment-1678889705