RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v14]
Srinivas Vamsi Parasa
duke at openjdk.org
Tue Aug 15 19:17:48 UTC 2023
On Fri, 4 Aug 2023 22:29:37 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:
>>> Also need to handle arraySort in file: share/gc/shenandoah/c2/shenandoahSupport.cpp, function: ShenandoahBarrierC2Support::verify around line 3000.
>>
>> Updated the code in ShenandoahBarrierC2Support as suggested.
>
>> @vamsi-parasa With fastdebug build I see the following error: Internal Error (jdk/src/hotspot/share/opto/escape.cpp:1196), pid=3543536, tid=3543559 fatal error: EA unexpected CallLeaf arraysort_stub
>>
>> Please take a look.
>
> This was fixed as well.
> @vamsi-parasa We need to preserve NaNs. The base (https://github.com/intel/x86-simd-sort) algorithm used doesn't preserve NaNs.
Thanks for catching this Sandhya! This is fixed now in the most recent commit. A preprocessing step is added to move the NaNs to the top of the array.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1679459713
More information about the hotspot-compiler-dev
mailing list