RFR: 8314247: JVMCI: expected int64_t but JavaThread::_held_monitor_count is of type intx

[Coleen Phillimore]

On Tue, 15 Aug 2023 20:39:47 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Fix graal error with @iklam's fix of making intx and int64_t synonyms.  Tested with new test in jvmci tests.
>
> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotVMConfigAccess.java line 325:
> 
>> 323: 
>> 324:         // Make sure the native type is still the type we expect.
>> 325:         if (cppType != null && !typeEquals(cppType, entry.type)) {
> 
> We have conditional code in Graal (e.g. [here](https://github.com/oracle/graal/blob/5097b1dabf01fd6d2ea1ea3b470060a138d49fa2/compiler/src/jdk.internal.vm.compiler/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java#L392-L405)) to deal with type changes in vmstructs so there's no need to fix it here. I'd prefer to not have this code do type aliasing like this as it might hide other changes we need to make in Graal.

Okay, if you can fix it in Graal, that would be great.  Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15295#discussion_r1295125128