RFR: 8311557: [JVMCI] deadlock with JVMTI thread suspension [v4]

Tue Aug 15 23:31:20 UTC 2023

On Tue, 15 Aug 2023 20:48:48 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   LibJVMCICompilerThreadHidden should just be EXPERIMENTAL
>
> src/hotspot/share/jvmci/jvmci_globals.hpp line 160:
> 
>> 158:           "[default: ./" LIBJVMCI_ERR_FILE "] (%p replaced with pid)")      \
>> 159:                                                                             \
>> 160:   product(bool, LibJVMCICompilerThreadHidden, true, EXPERIMENTAL,           \
> 
> This sounds more like a diagnostic flag than experimental.

It kind of is but because of the way the way [JVMCIGlobals::enable_jvmci_product_mode ](https://github.com/tkrodriguez/jdk/blob/tkr-hidden-fix/src/hotspot/share/jvmci/jvmci_globals.cpp#L169) works it seems easier to just make it experimental that becomes product like all the other special JVMCI flags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14799#discussion_r1295236623