RFR: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint [v2]

Fei Yang fyang at openjdk.org
Thu Aug 17 08:23:27 UTC 2023


On Thu, 17 Aug 2023 08:15:01 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 1236:
>> 
>>> 1234:     rmode_floor,
>>> 1235:     rmode_rint
>>> 1236:   };
>> 
>> Why not use the existing `RoundDoubleModeNode::rmode_ceil`, `RoundDoubleModeNode::rmode_floor` and `RoundDoubleModeNode::rmode_rint` instead?
>
> not sure it's good idea: RoundDoubleModeNode enum is purely C2 entity. Using some C2 enum in macroAssembler_riscv ( not c2_MacroAssembler_riscv) doesn't sound good.

Make sense. So we might further move the new assembler function `MacroAssembler::round_double_mode` into c2_MacroAssembler_riscv as it's only used for C2 for now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14991#discussion_r1296852355


More information about the hotspot-compiler-dev mailing list