RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError
Aleksey Shipilev
shade at openjdk.org
Thu Aug 17 11:08:26 UTC 2023
On Thu, 17 Aug 2023 10:48:49 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:
> I would like to fix this issue because it is difficult for testers to understand why the test failed.
> There is no risk as I just added an assertion message instead of exit code error.
> I would appreciate it if someone could review the fix.
Sorry, but we should not do this for two reasons:
1. We cannot be sure that non-zero exit code means we failed to create adapters.
2. stderr printout (as shown in the bug) provides enough diagnostic breadcrumbs.
-------------
Changes requested by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15329#pullrequestreview-1582373547
More information about the hotspot-compiler-dev
mailing list