RFR: 8309463: IGV: Dynamic graph layout algorithm [v5]

[emmyyin]

On Fri, 18 Aug 2023 13:57:41 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:

>> emmyyin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixing ws error
>
> src/utils/IdealGraphVisualizer/HierarchicalLayout/src/main/java/com/sun/hotspot/igv/hierarchicallayout/HierarchicalStableLayoutManager.java line 1255:
> 
>> 1253:                         found = false;
>> 1254: 
>> 1255:                         if (n.vertex == null && n.succs.size() <= 1 && n.preds.size() <= 1) {
> 
> I think `n.vertex == null` is always true and can be omitted

This is to make the loop break once we hit the non-dummy node where the edge goes from. I.e. for the edge (u,v) with lots of dummy nodes in between nodes u and v, we only want to remove the dummy nodes and then break the loop as soon as we are at node u.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14349#discussion_r1298602092