RFR: 8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError [v4]

[Aleksey Shipilev]

On Fri, 18 Aug 2023 14:12:51 GMT, Kimura Yukihiro <duke at openjdk.org> wrote:

>> I would like to fix this issue because it is difficult for testers to understand why the test failed.
>> There is no risk as I just added an assertion message instead of exit code error.
>> I would appreciate it if someone could review the fix.
>
> Kimura Yukihiro has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313901: [TESTBUG] test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java fails with java.lang.VirtualMachineError

Changes requested by shade (Reviewer).

test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java line 62:

> 60:         // Ignore adapter creation failures
> 61:         if (oa.getExitValue() != 0 && !oa.getStderr().contains("Out of space in CodeCache for adapters")) {
> 62:             throw new RuntimeException("VM finished with exit code " + oa.getExitValue());

We also need `oa.reportDiagnosticSummary();` in this block. Otherwise we lose debugging information when throwing this exception.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15329#pullrequestreview-1586604012
PR Review Comment: https://git.openjdk.org/jdk/pull/15329#discussion_r1299866761