RFR: 8314688: VM build without C1 fails after JDK-8313372 [v2]

Hao Sun haosun at openjdk.org
Tue Aug 22 06:34:27 UTC 2023


On Tue, 22 Aug 2023 03:47:51 GMT, xpbob <duke at openjdk.org> wrote:

>> [8314688: VM build without C1 fails after JDK-8313372]
>> 
>> ./configure --with-jvm-features=-compiler1 --with-debug-level=release
>> make images JOBS=32
>> 
>> 
>> jvmciCompilerToVMInit.o:make/hotspot/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp:252: more undefined references to `Compiler::is_intrinsic_supported(vmIntrinsicID)' follow
>
> xpbob has updated the pull request incrementally with one additional commit since the last revision:
> 
>   code format

src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp line 230:

> 228: static jboolean is_c1_supported(vmIntrinsics::ID id){
> 229:     jboolean supported = false;
> 230: #ifdef COMPILER1

Header `c1/c1_Compiler.hpp` at line 25 was introduced in JDK-8313372.
I suggest adding `#ifdef COMPILER1` directive for this header as well.

The same to the C2 case, i.e. header `opto/c2compiler.hpp`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15376#discussion_r1301035371


More information about the hotspot-compiler-dev mailing list