RFR: 8313530: VM build without C2 fails after JDK-8312579 [v2]

Vladimir Kozlov kvn at openjdk.org
Wed Aug 23 17:50:27 UTC 2023


On Wed, 23 Aug 2023 09:11:49 GMT, Gergö Barany <gbarany at openjdk.org> wrote:

>> The EnableVectorSupport flag is declared in `opto/c2_globals.hpp`, which is not included if `COMPILER2` is not set. But after my changes for [JDK-8312579](https://bugs.openjdk.org/browse/JDK-8312579) we try to access this flag in some places guarded by `#if COMPILER2_OR_JVMCI`.
>> 
>> This PR moves some flags from `c2_globals.hpp` to the shared `compiler_globals.hpp`, so that they are accessible even if C2 is disabled but JVMCI is enabled.
>
> Gergö Barany has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add copies of Vector API flags in jvmci_globals.hpp
>  - Revert "8313530: VM build without C2 fails after JDK-8312579"
>    
>    This reverts commit d82e89c469e91f78f9c2e5b28c725b0e1ba0fb8c.

Looks good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15384#pullrequestreview-1592116436


More information about the hotspot-compiler-dev mailing list