RFR: 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
Christian Hagedorn
chagedorn at openjdk.org
Thu Aug 24 11:57:53 UTC 2023
This patch fixes some internal IR framework failures after [JDK-8310308](https://bugs.openjdk.org/browse/JDK-8310308):
- `testlibrary_tests/ir_framework/tests/TestBadFormat.java` on Linux ppc64le:
- `applyIfCPUFeature` clauses are false and the rule is not run. We will therefore not hit the format violations which the test expects to find. The fix here is to remove the `applyIfCPUFeature` constraints as the test is only interested in properly reporting format violations.
- `testlibrary_tests/ir_framework/examples/IRExample.java` on Cascade Lake x86_64:
- On Cascade Lake, `failOn` constraints need the same "always true" handling as `counts` constraints. This was missed in JDK-8310308. I've added the same `try-catch` handling as in `RawCountsConstraint::parse()`:
https://github.com/openjdk/jdk/blob/97b94cb1cdeba00f4bba7326a300c0336950f3ec/test/hotspot/jtreg/compiler/lib/ir_framework/driver/irmatching/irrule/constraint/raw/RawCountsConstraint.java#L97-L104
Thanks to @MBaesken and @TheRealMDoerr for reporting this and helping with some pre-PR testing. Would you like to rerun your testing on PPC and Cascade Lake again?
Thanks,
Christian
-------------
Commit messages:
- 8314513: [IR Framework] Some internal IR Framework tests are failing after JDK-8310308 on PPC and Cascade Lake
Changes: https://git.openjdk.org/jdk/pull/15415/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15415&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8314513
Stats: 30 lines in 2 files changed: 5 ins; 12 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/15415.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15415/head:pull/15415
PR: https://git.openjdk.org/jdk/pull/15415
More information about the hotspot-compiler-dev
mailing list