RFR: 8312547: Max/Min nodes Value implementation could be improved [v4]

Quan Anh Mai qamai at openjdk.org
Thu Aug 24 16:02:57 UTC 2023


> Hi,
> 
> This patch removes the early return in `AddNode::Value` in case one of the inputs is a bottom, which may affect the value calculation of nodes such as `Min/MaxNode`.
> 
> Please kindly review, thanks very much.

Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'master' into values
 - address review
 - fix min/maxfp nodes
 - AddNode::Value should not return early
 - AddNode::Value should not return early

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15021/files
  - new: https://git.openjdk.org/jdk/pull/15021/files/4ae1ad36..0a117343

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15021&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15021&range=02-03

  Stats: 36909 lines in 1458 files changed: 18937 ins; 7251 del; 10721 mod
  Patch: https://git.openjdk.org/jdk/pull/15021.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15021/head:pull/15021

PR: https://git.openjdk.org/jdk/pull/15021


More information about the hotspot-compiler-dev mailing list