RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v26]

[Srinivas Vamsi Parasa]

On Thu, 24 Aug 2023 17:45:00 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add parallelSort benchmarking
>
> src/java.base/share/classes/java/util/Arrays.java line 398:
> 
>> 396:      */
>> 397:     public static void sort(double[] a) {
>> 398:          DualPivotQuicksort.sort(a, 0, 0, a.length);
> 
> Extra blank space before DualPivotQuicksort.

Please see this fixed in the latest commit.

> src/java.base/share/classes/java/util/DualPivotQuicksort.java line 2801:
> 
>> 2799:                 Arrays.arrayPartition(float.class, a, baseOffset, low, high, pivotIndices, Unsafe.ARRAY_INT_BASE_OFFSET, isDualPivot);
>> 2800:                 lower = pivotIndices[0];
>> 2801:                 upper = pivotIndices[1];
> 
> lower and upper are not used and overwritten on line 2822-2823.

Please see this fixed in the latest commit. Unlike the baseline, the variables `low` and `end` don't have to be initialized in this implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1304964322
PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1304963795