RFR: 8312547: Max/Min nodes Value implementation could be improved [v4]

Vladimir Kozlov kvn at openjdk.org
Fri Aug 25 01:36:15 UTC 2023


On Thu, 24 Aug 2023 16:02:57 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch removes the early return in `AddNode::Value` in case one of the inputs is a bottom, which may affect the value calculation of nodes such as `Min/MaxNode`.
>> 
>> Please kindly review, thanks very much.
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into values
>  - address review
>  - fix min/maxfp nodes
>  - AddNode::Value should not return early
>  - AddNode::Value should not return early

I am fine with fix and cleaning you did.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15021#pullrequestreview-1594675974


More information about the hotspot-compiler-dev mailing list