RFR: 8313430: [JVMCI] fatal error: Never compilable: in JVMCI shutdown

Aleksey Shipilev shade at openjdk.org
Fri Aug 25 19:20:08 UTC 2023


On Fri, 25 Aug 2023 18:58:31 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> VM shutdown involves calling Java code which can schedule further compilations by the CompileBroker. With `UseJVMCICompiler`, all compilations started once VM shutdown has begun are abandoned since they are unnecessary and can delay VM shutdown.
> 
> This PR makes `-XX:+AbortVMOnCompilationFailure` ignore such abandoned compilations.

Marked as reviewed by shade (Reviewer).

src/hotspot/share/compiler/compileBroker.cpp line 2228:

> 2226:       }
> 2227:     }
> 2228:     if (!task->is_success()  && !JVMCI::in_shutdown()) {

Nit: There is a double space in here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15433#pullrequestreview-1596371772
PR Review Comment: https://git.openjdk.org/jdk/pull/15433#discussion_r1306066075


More information about the hotspot-compiler-dev mailing list