RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long
Quan Anh Mai
qamai at openjdk.org
Sun Aug 27 12:41:42 UTC 2023
Hi,
This patch adds unsigned bounds and known bits constraints to `TypeInt` and `TypeLong`. This opens more transformation opportunities in an elegant manner as well as helps avoid some ad-hoc rules in Hotspot. The new constraints are applied to identity and value calls of the common nodes (Add, Sub, L/R/URShift, And, Or, Xor, bit counting, Cmp, Bool, ConvI2L/L2I), the detailed ideas for each node will be presented below.
In general, a `TypeInt/Long` represents a set of values `x` that satisfies: `x s>= lo && x s<= hi && x u>= ulo && x u<= uhi && (x & zeros) == 0 && (~x & ones) == 0`. These constraints are not independent, e.g. an int that lies in [0, 3] in signed domain must also lie in [0, 3] in unsigned domain and have all bits but the last 2 being unset. As a result, we must normalize the constraints (tighten the constraints so that they are optimal) before constructing a `TypeInt/Long` instance.
Please kindly review, thanks very much.
Testing
- [x] GHA
- [x] Linux x64, tier 1-3
- [ ] Linux x64, tier 4
-------------
Commit messages:
- whitespace
- fix tests for x86_32
- fix widen of ConvI2L
- problem lists
- format
- comment
- use properly_contains
- fix cast nodes
- fix Cast nodes
- fix Boolean test
- ... and 12 more: https://git.openjdk.org/jdk/compare/837cf85f...5fc5cf3a
Changes: https://git.openjdk.org/jdk/pull/15440/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15440&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8315066
Stats: 3851 lines in 36 files changed: 2069 ins; 1189 del; 593 mod
Patch: https://git.openjdk.org/jdk/pull/15440.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15440/head:pull/15440
PR: https://git.openjdk.org/jdk/pull/15440
More information about the hotspot-compiler-dev
mailing list