RFR: 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests [v5]

[Christian Hagedorn]

On Mon, 28 Aug 2023 08:30:07 GMT, Pengfei Li <pli at openjdk.org> wrote:

>> This patch removes `@require vm.flagless` annotations from HotSpot jtreg tests in `compiler/vectorization/runner`. All jtreg cases in this folder are invoked by test driver `VectorizationTestRunner.java` which checks both correctness and vectorizability (IR) for each test method. We added flagless requirement before because extra flags may mess with compiler control in the test driver for correctness check. But `flagless` has a side effect that it makes tests with extra flags skipped. So we propose to get rid of it now.
>> 
>> To adapt the removal of `@require vm.flagless`, a few checks are added in the test driver to skip the correctness check if extra flags make the compiler control not work. This patch also moves previously hard-coded flag `-XX:-OptimizeFill` in the test driver to conditions in IR checks.
>> 
>> Tested various of compiler control related VM flags on x86 and AArch64.
>
> Pengfei Li has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into flagless
>  - Remove useless conditions and imports
>  - Revert to the 1st commit and re-address comments
>  - Re-work correctness check to allow "-Xbatch"
>  - 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests
>    
>    This patch removes `@require vm.flagless` annotations from HotSpot jtreg
>    tests in `compiler/vectorization/runner`. All jtreg cases in this folder
>    are invoked by test driver `VectorizationTestRunner.java` which checks
>    both correctness and vectorizability (IR) for each test method. We added
>    flagless requirement before because extra flags may mess with compiler
>    control in the test driver for correctness check. But `flagless` has a
>    side effect that it makes tests with extra flags skipped. So we propose
>    to get rid of it now.
>    
>    To adapt the removal of `@require vm.flagless`, a few checks are added
>    in the test driver to skip the correctness check if extra flags make the
>    compiler control not work. This patch also moves previously hard-coded
>    flag `-XX:-OptimizeFill` in the test driver to conditions in IR checks.
>    
>    Tested various of compiler control related VM flags on x86 and AArch64.

I will also give this another spin in our testing.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15011#issuecomment-1695499328