RFR: 8314997: Missing optimization opportunities due to missing try_clean_mem_phi() calls [v2]

[Christian Hagedorn]

On Tue, 29 Aug 2023 16:43:44 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Vladimir's review
>
> src/hotspot/share/opto/cfgnode.cpp line 503:
> 
>> 501:   if (left_path == nullptr || right_path == nullptr) {
>> 502:     return false;
>> 503:   }
> 
> So the TOP input will fail next check. May be add comment about that.

I've added a comment at the next `if`.

> src/hotspot/share/opto/cfgnode.cpp line 1389:
> 
>> 1387:     return false;
>> 1388:   }
>> 1389:   assert(is_diamond_phi(), "sanity");
> 
> Add explicit check `> 0`

Good point, added.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15445#discussion_r1309712341
PR Review Comment: https://git.openjdk.org/jdk/pull/15445#discussion_r1309712015