RFR: 8310220: IGV: dump graph after each IGVN step at level 4 [v2]

[Roberto Castañeda Lozano]

On Wed, 21 Jun 2023 10:26:12 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Update compile phase list in IR test framework
>>  - Fix typo
>>  - Move bytecode parse dumping to a new IGV dump level 5
>>  - Merge branch 'master' into JDK-8310220
>>  - Dump graph before IGVN (by popular demand) and after IGVN (for symmetry)
>>  - Update IGV's README
>>  - Promote PHASE_MACH_ANALYSIS dump to print level 3 (since it runs once per compilation)
>>  - Dump Ideal graph after each IGVN step (in print level 4)
>
> src/hotspot/share/opto/phaseX.cpp line 896:
> 
>> 894:   const Type* newtype = type_or_null(n);
>> 895:   if (nn != n || oldtype != newtype) {
>> 896:     C->print_method(PHASE_AFTER_ITER_GVN_STEP, 4, n);
> 
> Should we keep this at level 4 and move the parser generated dumps to a new level 5? I often add dumps for these steps during IGVN but I rarely ever need the parser generated dumps.

Thanks for the feedback Christian, your suggestion makes sense. I will address this in a few weeks when I am back from vacation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14537#discussion_r1236825822