RFR: 8314837: 5 compiled/codecache tests ignore VM flags [v2]

Yi-Fan Tsai duke at openjdk.org
Wed Aug 30 22:42:48 UTC 2023


> TestSegmentedCodeCacheOption, TestCodeHeapSizeOptions, and TestPrintCodeCacheOption create processes with various flags. These flags include interpreter, tiered compilation, or segmented code cache, and they may conflict with the additionally specified vm flags. If propagating the flags and overwriting their values, the tests may not run in the intended way. This change adds `@requires vm.flagless` to these tests and keeps them creating processes while ignoring flags.
> 
> CodeCacheFullCountTest creates a process with specific flags: ReservedCodeCacheSize, UseCodeCacheFlushing, and MethodFlushing. This change requires `vm.flagless` for the same reason.
> 
> CheckCodeCacheInfo creates a process to print the code cache info while enabling Verbose. Both PrintCodeCache and Verbose are unlikely to conflict with additionally specified vm flags in a significant way, and the info printed stays the same. This change propagates the vm flags.
> 
> CheckCodeCacheInfo passes in fastdebug build.
> 
> make test TEST="test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java" JTREG="JAVA_OPTIONS=-XX:-TieredCompilation"
> make test TEST="test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java" JTREG="JAVA_OPTIONS=-Xint"
> make test TEST="test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java" JTREG="JAVA_OPTIONS=-XX:-PrintCodeCache"

Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:

  Mark CheckCodeCacheInfo flagless

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15485/files
  - new: https://git.openjdk.org/jdk/pull/15485/files/07f394c2..ab642336

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15485&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15485&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 2 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/15485.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15485/head:pull/15485

PR: https://git.openjdk.org/jdk/pull/15485


More information about the hotspot-compiler-dev mailing list