RFR: 8314837: 5 compiled/codecache tests ignore VM flags [v2]

Leonid Mesnik lmesnik at openjdk.org
Thu Aug 31 03:09:00 UTC 2023


On Wed, 30 Aug 2023 22:51:55 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:

>> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Mark CheckCodeCacheInfo flagless
>
> I marked CheckCodeCacheInfo with `vm.flagless`. The tested feature doesn't depend on other flags. The irrelevant flag `UnlockDiagnosticVMOptions` is also removed.

@yftsai The preferred fix is to use 'ProcessTools.createTestJvm ' to fork JVM with tested flags for most of tests 
It helps to ensure that corresponding functionality works for different modes like C2/C1 only, JMCI compiler and other modes. I think it would be better just to use it for
test/hotspot/jtreg/compiler/codecache/CheckCodeCacheInfo.java
test/hotspot/jtreg/compiler/codecache/CodeCacheFullCountTest.java. 

The vm.flagless is usually used for tests which are incompatible with any or most of external flags. It is fine to use it for cli tests.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15485#issuecomment-1700303916


More information about the hotspot-compiler-dev mailing list