RFR: 8314319: LogCompilation doesn't reset lateInlining when it encounters a failure.

[Vladimir Kozlov]

On Tue, 22 Aug 2023 02:48:26 GMT, Xin Liu <xliu at openjdk.org> wrote:

> This patch fixed a bug in LogCompilation. A compilation may encounter a failure after it processes 
> '<late_inline>' tag. Sometimes, C2 compiler would retry after tweaking options. In this case, it would retry it 
> without subsume_load. If we don't reset lateInlining, we may have trouble in the retry run. 
> 
> We also develop a unittest to verify that. A strip jit.xml is placed in test/resources/ directory. 
> 
> It's worth noting that 'mvn test' reports the 2 tests passed even without this patch. We can see the stacktrace
> of exceptions. This isn't an accident.  There are 2 reasons: 
> 1. LogParser::parse swallows any throwable in its exception handler.
> 2. surefire runs in parallel and can't capture the failure.
> 
> I am not sure they are by design. I manage to fix those 2 problems, but fixing them is beyond the scope of this
> patch. I would like to hear reviewer's feedbacks first.

Looks good.
I ran tier1 testing to make sure it passed our source code validation (for your new test). It passed.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15375#pullrequestreview-1605904457