RFR: 8321141: VM build issue on MacOS after JDK-8267532

[Jie Fu]

On Thu, 30 Nov 2023 23:29:48 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> [JDK-8267532](https://bugs.openjdk.org/browse/JDK-8267532) added new method `ciMethodData::exception_handler_bci_to_data()` which has `ShouldNotReachHere()` call on one exit without returning any value.
> 
> Unfortunately `ATTRIBUTE_NORETURN` attribute  in `ShouldNotReachHere()` seems don't work with older versions of Xcode.
> 
> The fix is to add `return` statement.
> 
> Tested with old Xcode (12.4) I have. Also tested with tier1 which includes builds.

LGTM

-------------

Marked as reviewed by jiefu (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16914#pullrequestreview-1758849463