RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v6]
Magnus Ihse Bursie
ihse at openjdk.org
Mon Dec 4 11:51:38 UTC 2023
On Thu, 30 Nov 2023 20:19:56 GMT, Srinivas Vamsi Parasa <duke at openjdk.org> wrote:
>> Raising the minimum gcc version is not done willy-nilly. (I feel a "You just don't ..." meme coming up)
>>
>> But you are saying that you want to skip building this library unless you have a gcc version that supports c++17?
>>
>> I still don't really like it. I'd like to hear someone else who can think clearly about this, if we want to go down this path, and start adding libraries that use C++17. Maybe @kimbarrett has some input?
>
>> But you are saying that you want to skip building this library unless you have a gcc version that supports c++17?
>>
> Yes, the request is to skip building the simdsort library if GCC version is < 8 as only GCC >= 8 supports C++17 features.
Then you must add logic to check for this. Now the build will just fail if building with an older gcc. That is not acceptable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1413761798
More information about the hotspot-compiler-dev
mailing list