RFR: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1

Tue Dec 5 08:25:36 UTC 2023

On Tue, 5 Dec 2023 08:09:34 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> The test fails with `-XX:CompileThreshold=100 -XX:TieredStopAtLevel=1` because `CompileMethodHolder::nonTrivialMethod` is unexpectedly OSR compiled but the test case has `isOSR() == false` (see line 197). The test is indeed not supposed to trigger an OSR compilation, and usually won't, but the loop is required to test tiered level transitions of a non-trivial method containing a loop. I simply changed the iterations to 1 to make sure that the backedge is never taken and thus prevent unexpected OSR compilations. The method will still be detected to have a loop and serve its purpose.
> 
> Thanks,
> Tobias

Looks good.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16964#pullrequestreview-1764324986