RFR: 8295166: IGV: dump graph at more locations

[Christian Hagedorn]

On Fri, 3 Nov 2023 16:02:38 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 5121:
>> 
>>> 5119: #endif
>>> 5120: }
>>> 5121: 
>> 
>> I'm not so sure about having an extra method `print_method_iter()` where the user need to keep track if a method is possibly repeated or not. I therefore suggest to only keep `print_method()` with its original signature and do the increment here like this:
>> 
>> 
>>   int iter = ++_igv_phase_iter[cpt];
>>   if (iter > 1) {
>>     ss.print(" %d", iter);
>>   }
>> 
>> Doing it this way we only add a number for the second time a phase is dumped again. I guess that's fine. But I'm open for other opinions about that.
>
> I agree with just having a `print_method`. I initially hesitated to modify `print_method` in the way you suggest, as it would then add iteration numbering to _all_ phases with no exceptions. But, it seems this is a feature we want then?

I think it could be useful for any repeated phase, if others also agree with that. And we would still keep the same name for phases that are only printed once and only add a number for the repeated dumps.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1383082103