RFR: 8310524: C2: record parser-generated LoadN nodes for IGVN [v2]

Tue Dec 5 12:26:36 UTC 2023

On Tue, 5 Dec 2023 11:55:53 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> This changeset fixes an issue where LoadN nodes were not recorded during bytecode parsing for later revisit in IGVN, in some cases resulting in missed optimization opportunities (see, e.g., the included new regression test).
>> 
>> Changes:
>> - Make sure to record newly added LoadN-nodes for IGVN in `GraphKit::make_load`.
>> - Add a regression test.
>> 
>> ### Testing
>> - tier1, tier2, tier3, tier4, tier5 (windows-x64, linux-x64, linux-aarch64, macosx-x64, macosx-aarch64)
>
> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address comments

Looks good, please re-run testing before integration to make sure the newly added assertion does not fail.

-------------

Marked as reviewed by rcastanedalo (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16967#pullrequestreview-1764950009