Integrated: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
Tobias Hartmann
thartmann at openjdk.org
Tue Dec 5 16:30:42 UTC 2023
On Tue, 5 Dec 2023 08:09:34 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> The test fails with `-XX:CompileThreshold=100 -XX:TieredStopAtLevel=1` because `CompileMethodHolder::nonTrivialMethod` is unexpectedly OSR compiled but the test case has `isOSR() == false` (see line 197). The test is indeed not supposed to trigger an OSR compilation, and usually won't, but the loop is required to test tiered level transitions of a non-trivial method containing a loop. I simply changed the iterations to 1 to make sure that the backedge is never taken and thus prevent unexpected OSR compilations. The method will still be detected to have a loop and serve its purpose.
>
> Thanks,
> Tobias
This pull request has now been integrated.
Changeset: 61d0db38
Author: Tobias Hartmann <thartmann at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/61d0db3838932d4030b05ffb04ee2b0215ea686e
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
Reviewed-by: rcastanedalo, chagedorn
-------------
PR: https://git.openjdk.org/jdk/pull/16964
More information about the hotspot-compiler-dev
mailing list