RFR: 8321225: [JVMCI] HotSpotResolvedObjectTypeImpl.isLeafClass shouldn't create strong references

Tue Dec 5 17:07:34 UTC 2023

On Mon, 4 Dec 2023 05:36:38 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> Checking for leaf Klasses requires seeing if the subklass field is null.  As part of the fix for JVMCI support for ZGC, JDK-8299229, it was changed to call into the runtime which had the side effect of creating a strong reference to an the class.  Since it's only checking for non-null it's ok to just perform thread directly as was done prior to JDK-8299229.  This avoids causing class unloading problems.

Looks good to me.

`java/util/stream/GathererTest.java` failure in GHA is known issue.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16943#pullrequestreview-1765669321
PR Comment: https://git.openjdk.org/jdk/pull/16943#issuecomment-1841241348