RFR: 8319111: Mismatched MemorySegment heap access is not consistently intrinsified [v4]

Tobias Hartmann thartmann at openjdk.org
Wed Dec 6 07:37:36 UTC 2023


On Sat, 2 Dec 2023 07:53:13 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Patch enables intrinsification of fromMemorySegment, intoMemorySegment APIs and their masked variants for mismatched memory segments i.e. heap based memory segments whose backing storage type differs from the vector type in which they are loaded to or stored from.
>> 
>> A load from a mismatched segment first moves the contents into type compatible vector followed by reinterpretation to desired vector type. This facilitates value forwarding from a preceding vector store as alias indices are computed using backing storage type.
>> 
>> Mismatched masked vector loads and stores are performed at byte granularity, this handles both narrowing and widening scenarios where vector lane size is smaller than backing storage element type and vice versa.
>> 
>> Following are the performance numbers of and existing JMH micro.
>> 
>> ![image](https://github.com/openjdk/jdk/assets/59989778/a0b177af-78ca-4ac8-b6b0-bfe3655b16a6)
>> 
>> Please review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correting BIG_ENDIAN_ONLY check

Changes look good to me and all tests passed.

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16888#pullrequestreview-1766847708


More information about the hotspot-compiler-dev mailing list