RFR: 8310524: C2: record parser-generated LoadN nodes for IGVN [v2]

Tobias Hartmann thartmann at openjdk.org
Wed Dec 6 09:03:36 UTC 2023


On Wed, 6 Dec 2023 08:47:45 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/igvn/TestLoadNIdeal.java line 54:
>> 
>>> 52:         p[0] = new A();
>>> 53: 
>>> 54:         // Dummy is not compiled and hence not inlined => Escape analysis
>> 
>> Is there a reason you are not using [DontInline](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/lib/ir_framework/DontInline.java) to prevent inlining of `dummy`?
>
> No particular reason. I checked, and `@DontInline` also makes the test work as expected. Is it preferable to use `@DontInline`?

Yes, I think `@DontInline` would be clearer here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16967#discussion_r1416950959


More information about the hotspot-compiler-dev mailing list