RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v19]

Emanuel Peter epeter at openjdk.org
Wed Dec 6 15:45:08 UTC 2023


On Tue, 28 Nov 2023 10:39:40 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   For Faye: remove 64-bit platform requirement in test
>
> src/hotspot/share/opto/superword.hpp line 251:
> 
>> 249: //        and invar is nullptr if no invar dependency.
>> 250: class AlignmentSolution {
>> 251: private:
> 
> `private` is implied and can be removed.

I would prefer to keep it. I think it is nicer to read, I make the intention explicit. Let me know if you disagree.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1417532878


More information about the hotspot-compiler-dev mailing list