RFR: 8310190: C2 SuperWord: AlignVector is broken, generates misaligned packs [v21]

[Emanuel Peter]

On Thu, 7 Dec 2023 07:20:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> I replaced `vw` with `vector_width`, there were relatively few occurances. But if I replace `aw` with `alighment_width` then everything becomes much more "wordy", all lines become much longer. I would like to keep `aw`, I think it is much more readable then the long form. What do you think?
>
> Thanks. Okay, I see your point. I agree that we can go with `aw` in the local scope of `pack_alignment_solution`/`AlignmentSolver`  for readability purposes (and you explain what it is in the comments/print statements). However, I think the `AlignmentSolution` class should use the full name `alignment_width` as a general property to store/return. What are your thoughts about that?

Ok, that sounds good! I did the update.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14785#discussion_r1418494908