RFR: 8295166: IGV: dump graph at more locations [v2]

[Daniel Lundén]

On Thu, 7 Dec 2023 08:48:45 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address comments
>
> src/utils/IdealGraphVisualizer/README.md line 31:
> 
>> 29: * `N=1`: after parsing, before matching, and final code (also for failed
>> 30:   compilations, if available)
>> 31: * `N=2`: additionally, after every major phase (including loop opts)
> 
> Suggestion:
> 
> * `N=2`: additionally, after every major phase

Fixed, thanks

> test/hotspot/jtreg/compiler/lib/ir_framework/CompilePhase.java line 103:
> 
>> 101:     BEFORE_MATCHING("Before matching"),
>> 102:     MATCHING("After matching", RegexType.MACH),
>> 103:     MACH_ANALYSIS("After mach analysis", RegexType.MACH),
> 
> Could you move this line to after `POSTALLOC_EXPAND("Post-Allocation Expand", RegexType.MACH)`, for consistency with the order in which phases are defined in `phasetype.hpp`?

Yes, fixed now. In general, I suspect there are other inconsistencies between `CompilePhase.java` and `phasetype.hpp`. I'll add it as an item to the cleanup RFE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1418692221
PR Review Comment: https://git.openjdk.org/jdk/pull/16120#discussion_r1418693811