RFR: 8320139: [JVMCI] VmObjectAlloc is not generated by intrinsics methods which allocate objects

Tom Rodriguez never at openjdk.org
Thu Dec 7 16:50:28 UTC 2023


On Tue, 5 Dec 2023 18:26:57 GMT, Raphael Mosaner <duke at openjdk.org> wrote:

> This PR exports a pointer to `JvmtiExport::_should_notify_object_alloc` via JVMCI to enable intrinsification of unsafe allocations in accordance to C2.

Marked as reviewed by never (Reviewer).

src/hotspot/share/jvmci/jvmciCompilerToVM.hpp line 118:

> 116:     static int data_section_item_alignment;
> 117: 
> 118:     static int* _should_notify_object_alloc;

I think a small comment wouldn't hurt.  Something like:

// Pointer to JvmtiExport::_should_notify_object_alloc.  Exposed as an int* instead of an address so the
// underlying type is part of the JVMCIVMStructs definition.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16980#pullrequestreview-1770613118
PR Review Comment: https://git.openjdk.org/jdk/pull/16980#discussion_r1419277487


More information about the hotspot-compiler-dev mailing list