RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" [v3]

[Andrew Haley]

On Fri, 8 Dec 2023 02:24:45 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright
>
> src/hotspot/share/c1/c1_globals.hpp line 280:
> 
>> 278:   develop(intx, NMethodSizeLimit, (64*K)*wordSize,                          \
>> 279:           "Maximum size of a compiled method.")                             \
>> 280:           range(0, 1*M)                                                     \
> 
> Shouldn't this be defined in platform-specific code, along with a comment explaining why 1MB was chosen?

It could be, and I would have suggested doing so, but I am unaware of any circumstances in which ginormous C1-compiled methods are of any benefit to any port.

> What were these large sizes of NMethodSizeLimit meant to test? Removing these test cases because of a problem with aarch64 seems wrong, unless these test cases really have no value for other platforms.

That would be my guess.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16951#discussion_r1420111316
PR Review Comment: https://git.openjdk.org/jdk/pull/16951#discussion_r1420112021