RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" [v3]

Dean Long dlong at openjdk.org
Fri Dec 8 19:59:20 UTC 2023


On Fri, 8 Dec 2023 14:00:30 GMT, Daniel Lundén <duke at openjdk.org> wrote:

>> It could be, and I would have suggested doing so, but I am unaware of any circumstances in which ginormous C1-compiled methods are of any benefit to any port.
>
> I think a 1MB upper bound is sensible for all platforms (see my other comment below). I'll add a comment explaining the choice, thanks. Please let me know if you think a larger bound is more suitable. In that case, we should also apply @theRealAph's improved aarch64 fix above for `const2reg` (or set a platform-specific bound of 1MB for aarch64).

I don't know what a typical nmethod size is for C1, but I can imagine hitting the 1MB limit by doing something like stress testing with increased inlining limits.  Or maybe very large initialization methods in the future thanks to Leyden AOT or computed constants?  So I guess I'm leaning slightly towards fixing the aarch64 issue now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16951#discussion_r1420975058


More information about the hotspot-compiler-dev mailing list