RFR: 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes

Tom Rodriguez never at openjdk.org
Mon Dec 11 22:01:58 UTC 2023


On Tue, 5 Dec 2023 19:00:51 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> HotSpotJVMCIRuntime.resolvedJavaTypes implements a weak value map but is lacking code to clean out cleared weak references.  In normal mixed execution this isn't likely to get big and generally isolates are shutdown frequently so this doesn't lead to problems.  In Xcomp mode with tests that stress unloading this becomes more problematic.  In the worst case is still doesn't lead to large heaps but does make the idle heap larger than required.
> 
> This PR adds ReferenceQueue based cleaning of reclaimed values.  Testing in the context of a long running isolate shows that they are no longer accumulating.

I pushed some expanded comments and renames.  I also adjusted some types that were weaker than the actual type which removed a bit of casting.  Testing was clean.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16981#issuecomment-1850957119


More information about the hotspot-compiler-dev mailing list