RFR: 8321648: Integral gather optimized mask computation.

Tobias Hartmann thartmann at openjdk.org
Wed Dec 13 07:33:37 UTC 2023


On Mon, 11 Dec 2023 10:33:05 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> While you are at it, you can change the `address` operand of these to only accept no-index ones, removing the need of the `lea` instruction.
>
>> While you are at it, you can change the `address` operand of these to only accept no-index ones, removing the need of the `lea` instruction.
> 
> Hi @merykitty ,  Memory patterns fold address generation components (base , index, scale) into instruction encoding thus eliminating a need to emit explicit ADD, MUL instruction sequence to compute address, saving lea may prevent folding memory patterns and may prove to be costly.

@jatin-bhateja Could you elaborate on what the failure mode for the incorrect instruction attribution would look like? Is this just inefficient execution or would it lead to a crash?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17048#issuecomment-1853399018


More information about the hotspot-compiler-dev mailing list