RFR: 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes [v2]

[Vladimir Kozlov]

On Mon, 11 Dec 2023 22:01:58 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> HotSpotJVMCIRuntime.resolvedJavaTypes implements a weak value map but is lacking code to clean out cleared weak references.  In normal mixed execution this isn't likely to get big and generally isolates are shutdown frequently so this doesn't lead to problems.  In Xcomp mode with tests that stress unloading this becomes more problematic.  In the worst case is still doesn't lead to large heaps but does make the idle heap larger than required.
>> 
>> This PR adds ReferenceQueue based cleaning of reclaimed values.  Testing in the context of a long running isolate shows that they are no longer accumulating.
>
> Tom Rodriguez has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into tkr-clean-weak
>  - Comment and types improvements
>  - 8321288: [JVMCI] HotSpotJVMCIRuntime doesn't clean up WeakReferences in resolvedJavaTypes

Looks good as far as I can understand.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16981#pullrequestreview-1780300803