RFR: 8321823: Remove redundant PhaseGVN transform_no_reclaim [v2]

[Paul Hohensee]

On Tue, 12 Dec 2023 17:29:50 GMT, Joshua Cao <duke at openjdk.org> wrote:

>> `PhaseGVN::transform` is just a one line wrapper around `PhaseGVN::transform_no_reclaim`. Looking at the history, they had different functionality in 2008, but since have become the same thing. We prefer to keep `PhaseGVN::transform` because it has hundreds of callsites, while the other only has a few callsites that are shown in the PR.
>> 
>> Passes tier1 locally on my Linux machine.
>
> Joshua Cao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix formatting

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17071#pullrequestreview-1780536069