RFR: 8320682: [AArch64] C1 compilation fails with "Field too big for insn" [v4]
Daniel Lundén
duke at openjdk.org
Thu Dec 14 08:47:13 UTC 2023
> This changeset fixes an issue where addresses for float and double constants on aarch64 were sometimes out of range for PC-relative offsets using `adr`.
>
> Changes:
> - Set an upper bound of `1M` for the flag `NMethodSizeLimit`, ensuring that float and double constants are in range for `adr`.
> - Revise tests in `TestC1Globals.java` to use the new upper bound of `1M` for `NMethodSizeLimit`. Also, remove no longer applicable tests in `TestC1Globals.java`.
>
> ### Testing (in progress)
> Platforms: windows-x64, linux-x64, linux-aarch64, macosx-x64, macosx-aarch64
> - tier1, tier2, tier3, tier4, tier5
> - Targeted and repeated tests for `TestC1Globals.java` in all tiers
Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
Add comment explaining 1MB restriction
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/16951/files
- new: https://git.openjdk.org/jdk/pull/16951/files/d19040e5..1d0515b7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=16951&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=16951&range=02-03
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/16951.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/16951/head:pull/16951
PR: https://git.openjdk.org/jdk/pull/16951
More information about the hotspot-compiler-dev
mailing list