RFR: 8319793: C2 compilation fails with "Bad graph detected in build_loop_late" after JDK-8279888 [v7]

[Roland Westrelin]

On Fri, 15 Dec 2023 12:52:45 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert "Update src/hotspot/share/opto/castnode.hpp"
>>    
>>    This reverts commit 356c91cca911ed486f9f87f3eff53ce21e1e3ec9.
>>  - Revert "Update src/hotspot/share/opto/memnode.hpp"
>>    
>>    This reverts commit bdb731ea562f314f44d327f7243ef5cf9ad40b2e.
>
> src/hotspot/share/opto/loopopts.cpp line 360:
> 
>> 358:         // dependent nodes end up at the lowest/nearest dominating check in the graph. To ensure that these Loads/Casts
>> 359:         // do not float above any of the dominating checks (even when the lowest dominating check is later replaced by
>> 360:         // yet another dominating check), we need to pin them at the lowest dominating check.
> 
> Should we also add this updated comment to `ifnode.cpp:569` and `ifnode.cpp:1536`?

Yes, right. Thanks! I updated the change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16886#discussion_r1428036421