RFR: 8322195: RISC-V: Minor improvement of MD5 instrinsic [v2]

Fei Yang fyang at openjdk.org
Tue Dec 19 01:40:42 UTC 2023


On Mon, 18 Dec 2023 11:03:03 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review this minor patch to improve MD5 instrinsic?
>> Thanks!
>> 
>> ## Test
>> 
>> tests (`find test/ -iname "*md5*.java"`) passed.
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - add space
>  - Add some comment

Looks good to me except for the nit. Thanks.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 4163:

> 4161:     // in the following code, it does not care about the content of
> 4162:     // higher 32-bits in state[x]. Based on this observation,
> 4163:     // we can apply futher optimization, which is to just ignore the

Nit: /futher/further/

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17123#pullrequestreview-1787955905
PR Review Comment: https://git.openjdk.org/jdk/pull/17123#discussion_r1430811402


More information about the hotspot-compiler-dev mailing list